Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(l10n): propfind error message translation source #6320

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix(l10n): propfind error message translation source #6320

merged 1 commit into from
Sep 5, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Sep 4, 2024

@st3iny
fix(l10n): propfind error message translation source
343fe47 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny added 3. to review Waiting for reviews bug language l10n and translations labels Sep 4, 2024
@st3iny st3iny self-assigned this Sep 4, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.73%. Comparing base (96fb2c7) to head (343fe47).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/propfindErrorParse.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #6320   +/-   ##
=========================================
  Coverage     23.73%   23.73%           
  Complexity      454      454           
=========================================
  Files           247      247           
  Lines         11731    11731           
  Branches       2213     2223   +10     
=========================================
  Hits           2784     2784           
  Misses         8627     8627           
  Partials        320      320
Flag Coverage Δ
javascript 15.33% <0.00%> (ø)
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

miaulalala
miaulalala approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am spreed

GVodyanov
GVodyanov approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@GVodyanov GVodyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm an idiot

@GVodyanov GVodyanov merged commit 74174c0 into main Sep 5, 2024
34 of 35 checks passed
@GVodyanov GVodyanov deleted the fix/l10n/propfind-error branch September 5, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@GVodyanov GVodyanov GVodyanov approved these changes

Assignees

@st3iny st3iny

Labels
3. to review Waiting for reviews bug language l10n and translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@st3iny @miaulalala @GVodyanov